mdolab / mdolab/openconcept

`takeoff|h` does not work as expected with takeoff phases

Open
#66 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
62
Forks
43
PR merge metrics
No merged PRs in 30d

Description

Description

The takeoff|h parameter does set the takeoff and landing altitudes for the BasicMission and MissionWithReserve (though the ground roll in the BasicMission uses its own fltcond|h value). However, the takeoff phase altitudes in the FullMissionAnalysis and FullMissionWithReserve are actually set via each takeoff phases fltcond|h. The takeoff's rotation phase does have an h_initial variable which sets its initial altitude, but then only the obstacle height is connected to the climb phase's initial altitude (not h_initial + obstacle height as you may expect).

We typically leave the takeoff altitude at 0 ft. In this case, everything works as expected, so this does not mean that past cases are wrong. However, future users may adjust this value and they would not get the expected result if they are using the BasicMission with the ground roll phase or either full mission with takeoff phases.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing how takeoff|h is propagated in BasicMission, MissionWithReserve, FullMissionAnalysis, and FullMissionWithReserve, then inspect the takeoff rotation and climb phases. Compare their altitude connections and verify that the configured takeoff altitude produces consistent phase altitudes and obstacle handling across these mission types.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
performance
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.