Avoid changing strings when complexifying
Nobody has claimed this yet.
- Dominant language
- Fortran
- Stars
- 1
- Forks
- 4
- PR merge metrics
- No merged PRs in 30d
Description
## Description
The current pattern matching does not check whether the patterns are used in strings that are printed out. For example in mdolab/adflow#229, I ran into a problem where a sequence of `"======"` being used as a separator was converted to `".ceq..ceq..ceq."`. This does not necessarily break the compilation, but it can if the line exceeds the character limit.
### Steps to reproduce issue
1. Build the complex version of ADflow.
2. Check `src_cs/BCData.F90` for `.ceq..ceq..ceq.`
### Current behavior
Some strings are substituted with complexified functions.
### Expected behavior
Strings should stay the same.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the issue by building the complex version of ADflow and inspecting src_cs/BCData.F90 for .ceq..ceq..ceq. strings. Start with the current pattern-matching behavior and verify that quoted strings remain unchanged while other patterns are complexified.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- fortran
- Domain
- compilers
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100