`root_add_dict` should fail if the dict does not match exactly
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 7
- Forks
- 27
- PR merge metrics
- No merged PRs in 30d
Description
Description
Say you have a dictionary in the reference file, and use root_add_dict for training/testing. If the reference dictionary is a superset of the dictionary generated from testing, then the test is considered to pass, since we just loop over the generated dictionary keys, rather than the reference dictionary keys.
Steps to reproduce issue
Imagine if the reference JSON file contained the following dictionary
{'a':1, 'b':2, 'c':3}
and the dictionary generated by the test is
{'a':1, 'b':2}
Current behavior
root_add_dict will consider the test to be successful.
Expected behavior
The test should fail.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Search the repository for the root_add_dict entry point and read how it compares the generated and reference dictionaries. Reproduce the case where the reference has an extra key, then update the comparison so that missing reference keys are detected. Add or adjust a regression test covering the extra-key case and run the relevant test suite.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- testing-qa
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100