mdolab / mdolab/adflow

"V" not available as a design variable

Open
#96 0 comments 0 reactions 1 assignee View on GitHub

@marcomangano is already working on this.

Since Nov 27, 2020.

Dominant language
Fortran
Stars
332
Forks
124
PR merge metrics
No merged PRs in 30d

Description

Description

We currently cannot include the inflow velocity V among the design variables due to an incomplete variable setup routine.
This input variable must be included in the available set, which already includes mach, alpha, etc...
The bugfix will also require modifications to BaseClasses

Steps to reproduce issue

On a working runscript for ADflow, include 'V' among the design variables with:
ap.addDV('V') where ap is your AeroProblem instance.

Current behavior

The initialization terminates abruptly with the following message:

File "<path-to-baseclasses>/baseclasses/pyAero_problem.py", line 525, in addDV
    raise ValueError('%s is not a valid design variable' % key)
ValueError: V is not a valid design variable
Expected behavior

ADflow should run and evaluate the sensitivities, including those w.r.t. the inflow velocity

Code versions
  • BaseClasses v1.2.2
  • ADflow v2.2.1

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.