mdolab / mdolab/adflow

Discontinuities in post-processed twist and t/c distributions

Open
#69 7 comments 0 reactions 0 assignees View on GitHub

@anilyil is already working on this.

Since Jul 8, 2023.

  • #289 by @lucaeros — merged
  • #296 by @anilyil — open
bug good first issue
Dominant language
Fortran
Stars
332
Forks
124
PR merge metrics
No merged PRs in 30d

Description

Type of issue

What types of issue is it?

  • Bugfix (non-breaking change which fixes an issue)

Description

The post-processed twist and t/c distributions that ADflow outputs sometimes have spurious discontinuities and jumps. This is related to the script jumping between the upper and lower trailing edges of the geometry, or some equivalent jump, while calculating the twist using the farthest two points in a section.

For examples, see the twist and t/c plots in:

Expected behavior

There shouldn't be spurious discontinuities and jumps.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the post-processing code that computes twist and t/c distributions, then trace the calculation using the farthest two points in each section. Compare how the script selects the upper and lower trailing edges and inspect the open pull request for existing work. Done means the generated distributions no longer contain spurious discontinuities or jumps.

Written by the indexing model from the issue text.

Assessment

Tech stack
fortran
Domain
backend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.