mdolab / mdolab/adflow

Clear out compiler warnings and remarks

Open
#53 2 comments 0 reactions 1 assignee View on GitHub

Nobody has claimed this yet.

enhancement installation
Dominant language
Fortran
Stars
332
Forks
124
PR merge metrics
No merged PRs in 30d

Description

Type of issue

  • Code formatting

Description

We have a bunch of warnings and remarks generated during compilation of ADflow. PR #52 addresses most of these issues; however, we still have some warnings remaining:

  1. Complex builds still complain about missing modules. @nwu63 and I will work on this with the PR #52.
  2. The forces array is defined as an output variable with the getForces_b routine, but is not used. I did not modify this now, but we can edit the call signature and/or modify the intent. The warning looks like this:
../warping/getForces.F90(124): warning #6843: A dummy argument with an explicit INTENT(OUT) declaration is not given an explicit value.   [FORCES]
  1. With intel compilers, we get a lot of remarks about output formats from fortran files. These remarks look like this:
remark #8291: Recommended relationship between field width 'W' and the number of fractional digits 'D' in this edit descriptor is 'W>=D+7'.

Here is the explanation of this from doctor fortran himself: https://software.intel.com/en-us/forums/intel-fortran-compiler/topic/635137
This can be easily fixed, but we need to check if all outputs look okay after the fix.
4. There are a bunch of warnings generated by the f2py wrapping. These contain:

warning #1224: #warning directive: "Using deprecated NumPy API, disable it by "          "#defining NPY_NO_DEPRECATED_API NPY_1_7_API_VERSION"

and a bunch of

libadflowmodule.c(11948): warning #556: a value of type "void (*)(int *, int *, void (*)(char *, int *), int *)" cannot be assigned to an entity of type "f2py_init_func"
    f2py_communication_def[i_f2py++].func = sendrequests;

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.