mdolab / mdolab/adflow

Add AMG performance tests

Open
#361 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement maintenance
Dominant language
Fortran
Stars
332
Forks
124
PR merge metrics
No merged PRs in 30d

Description

Description of feature

The AMG tests only check if the flow and adjoint solvers converge. We should add tests to make sure the rates of convergence follow the expected trends when using different solver options.

There are some challenges to doing this. Our current regression testing infrastructure is not well-suited to testing performance. In addition, differences in performance might only show up on larger cases.

See #359 for some related discussion

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading the existing AMG flow and adjoint solver tests, then review the related discussion in #359 and the regression-testing infrastructure. Define how larger cases and solver options can measure convergence-rate trends; done means the tests verify the expected performance trends rather than only solver convergence.

Written by the indexing model from the issue text.

Assessment

Tech stack
fortran
Domain
performance, testing
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.