setRotationRate for local blocks does not work correctly
Nobody has claimed this yet.
- Dominant language
- Fortran
- Stars
- 332
- Forks
- 124
- PR merge metrics
- No merged PRs in 30d
Description
Description
The setRoationRate function in pyADflow has a bug that prevents assigning specific rotation rates to individual blocks. Instead, the rate is applied to n cgns blocks starting form the first block number.
PR #323 potentially has fixes for this bug, however due to inactivity and incompleteness that PR has been closed.
Steps to reproduce issue
PR #323 identified this bug, but no tests or MWE was provided.
Current behavior
Currently ADflow applies the rotation rate the first n blocks instead of targeting specific blocks provided by the user.
Expected behavior
Rotation rates should be applied to specific blocks provided by the user.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing PR #323 and tracing the pyADflow setRotationRate implementation to understand how block selections and rotation rates are handled. Reproduce the issue with a multi-block case, then add a regression test covering specific blocks and confirm rates are no longer applied to the first n blocks.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- fortran, python
- Domain
- hpc
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100