mdolab / mdolab/adflow

AMG regression test fails with three levels

Open
#324 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Fortran
Stars
332
Forks
124
PR merge metrics
No merged PRs in 30d

Description

Description

Nightly docker integration tests on the u22-gcc-ompi-stable x86 image is failing on the AMG test (see here). This seems to be a result of a newly merged PR https://github.com/mdolab/adflow/pull/235.

The test_amg.py:TestAMGReal_2_different_levels_and_iterations.test_convergence AMG regression test is failing to converge.

Steps to reproduce issue

This can be reproduced with the failed image pushed to DockerHub, i.e., mdolab/public:u22-gcc-ompi-stable-amd64-failed (Digest: sha256:76e6eb4be1c823744ec7cfc46fa38e5edc9897b8cf9d54dc08d208cd5db1d2f2). Using the image, download the input test files, and run only the AMG regression tests testflo -s -v -n 1 test_amg.py.

Using the previous commit git checkout 559a1deee07126c521e7a2e18f3968dd0ef7b061, rebuilding and pip installing, then all AMG tests do pass successfully.

Current behavior

Currently, the case does not converge and test fails.

Expected behavior

Case should converge and test pass.

Code versions

Docker image mdolab/public:u22-gcc-ompi-stable-amd64-failed downloaded today (Digest: sha256:76e6eb4be1c823744ec7cfc46fa38e5edc9897b8cf9d54dc08d208cd5db1d2f2)

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Use the failed Docker image mdolab/public:u22-gcc-ompi-stable-amd64-failed and run testflo -s -v -n 1 test_amg.py as described. Start with test_amg.py:TestAMGReal_2_different_levels_and_iterations.test_convergence, then compare behavior with commit 559a1deee07126c521e7a2e18f3968dd0ef7b061. Done means the AMG case converges and the regression test passes.

Written by the indexing model from the issue text.

Assessment

Tech stack
docker, fortran
Domain
testing-qa
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.