mdolab / mdolab/adflow

MPhys wrapper: Standardize ADflow wrapper

Open
#197 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

mphys
Dominant language
Fortran
Stars
332
Forks
124
PR merge metrics
No merged PRs in 30d

Description

Description of feature

The addition of flight conditions with the adflow wrapper should be standardized so that we can use the common naming convention with other aero solvers. currently, adflow still uses aeroproblems during configure and this requires extra manual connections.

Also with these changes, we can clean up the wrapper a bit and remove the unnecessary methods that were called in configure.

This only applies to the MPhys wrapper which is moved to ADflow in #196 . This issue is moved from the MPhys repo: https://github.com/OpenMDAO/mphys/issues/61

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading the MPhys wrapper moved to ADflow in issue #196 and its configure path. Compare the wrapper's flight-condition and AeroProblem naming with the common aero-solver convention, then identify the unnecessary methods called during configure. Done means standardized naming, no unnecessary configure calls, and no extra manual connections.

Written by the indexing model from the issue text.

Assessment

Tech stack
fortran
Domain
hpc
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.