mdolab / mdolab/adflow

Incorrect Y+ printout in complex mode

Open
#162 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Fortran
Stars
332
Forks
124
PR merge metrics
No merged PRs in 30d

Description

Description

When running ADflow in complex mode, the exponents in the Y+ printout are clearly wrong.

Steps to reproduce issue

Run a complex ADflow simulation and monitor the Y+

Current behavior

The Y+ printout will look like this:

-------------------------------------------------
|                    Y+_max                     |
-------------------------------------------------
0.2461515118008841-311 +0.2419075202248823E-311i

The exponent of the real part is too small, identical to the complex one, and missing the E character.
The complex exponent itself looks suspiciously small as well.

Expected behavior

Show the correct order of magnitude for the real (and complex) components of the Y+

Code versions
  • ADflow v2.5.2 (HEAD)

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by running a complex-mode ADflow simulation and locate the code that produces the Y+ printout. Compare the real and imaginary exponent formatting with the expected order of magnitude, then verify that both components display correct exponents and include the E character where appropriate.

Written by the indexing model from the issue text.

Assessment

Tech stack
fortran
Domain
hpc
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.