SA-R implementation is incorrect
Open
Nobody has claimed this yet.
bug
- Dominant language
- Fortran
- Stars
- 332
- Forks
- 124
- PR merge metrics
- No merged PRs in 30d
Description
Description
There are two problems with the SA-R implementation here (the same code also appears in the blockette code) when compared to the TMR website:
- The min function is missing the minus omega in the second argument. As a result, the min always evaluates to zero and SA-R solutions are identical to SA.
- The if statement is checked for both strain and vorticity production, but SA-R is only valid for vorticity production.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Inspect src/turbulence/sa.F90 at lines 269-273 and locate the same SA-R code in the blockette implementation. Compare both implementations with the SA-R formulation on the linked TMR website, then verify that the minimum expression and production-condition handling match it and that SA-R no longer produces identical results to SA.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- fortran
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 48/100