Using blockettes with non-default simulations should raise an error and quit.
@anilyil is already working on this.
Since Jan 20, 2021.
- Dominant language
- Fortran
- Stars
- 332
- Forks
- 124
- PR merge metrics
- No merged PRs in 30d
Description
Description of feature
Blockettes only work with steady state RANS simulations with the SA turbulence model on non-rotating reference frames. Any combination of options should automatically disable this feature or rise an error so that these simulations work properly.
Potential solution
We can either raise an error, or automatically disable blockettes when any feature that does not have a blockette implementation is used. This can be done at either pyadflow or fortran level.
I suggest modifying the option on pyADflow level automatically if the user requested one of these options but did not specify blockettes in the runscript. This way, the default will be adjusted automatically and no further action is required. If the user specified blockettes, then we should raise an error and quit.
I will also add a section on blockettes to the documentation so that the developers are aware of this coding approach.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.