mdolab / mdolab/OpenAeroStruct
Partial derivatives bug in Rotate (twist) component when rotate_x = False
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 281
- Forks
- 135
- PR merge metrics
- No merged PRs in 30d
Description
Description
Partial derivatives seem wrong for the Rotate component in the geometry model when setting rotate_x=False. By default, OAS sets rotate_x=True and partials are correct in that case.
OAS currently does not test partials for rotate_x=False, which we should.
Steps to reproduce issue
In test_geometry_mesh_transformation.py, set rotate_x=False for Rotate components. Test will fail due to wrong partial derivatives.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with test_geometry_mesh_transformation.py and set rotate_x=False for the Rotate component to reproduce the failing partial-derivative check. Then trace the Rotate component in the geometry model to find the incorrect derivatives. Done means the derivatives are corrected and the test covers rotate_x=False without failing.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- backend, testing-qa
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100