mdolab / mdolab/OpenAeroStruct

Trim drag example doesn't do what it says

Open
#349 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
281
Forks
135
PR merge metrics
No merged PRs in 30d

Description

Description

The drag_polar.py example purports to have a trim drag option that can be toggled. However, it uses the OM BalanceComp to achieve this, but it doesn't have a Newton solver with which to drive the balance comp, so in effect it does nothing at all and the trim calc is wrong / not happening.

Steps to reproduce issue

Run drag_polar.py with trim drag turned on

Current behavior

CM not being balanced by tail rotation

Expected behavior

CM balanced to 0 by tail rotation

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the drag_polar.py example and inspect how the trim drag option uses OM BalanceComp. Run the example with trim drag enabled, then verify that tail rotation drives CM to 0 and that the trim calculation is active.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.