mdolab / mdolab/OpenAeroStruct

Refactor / enhance / document the plot functions

Open
#341 0 comments 0 reactions 1 assignee View on GitHub

@kanekosh is already working on this.

Since Sep 1, 2020.

Dominant language
Python
Stars
281
Forks
135
PR merge metrics
No merged PRs in 30d

Description

Type of issue

  • New feature (non-breaking change which adds functionality)
  • Documentation update

Description

Plot scripts plot_wing.py, plot_wingbox.py have a lot to be improved.

  • Refactor: Two scripts have duplicated methods e.g. save_video. We should create a parent class to put the common parts.
  • Refactor: API for plot should be unified for all cases; specify the type of case (multipoint or not, wingbox or not) as an argument to the plot function.
  • We should be able to plot multipoint non-wingbox cases, as well as single-point wingbox ones.
  • plot_wing should be callable in the python script.
  • Update the document on visualization. In particular, add 1) how to run the plotter, 2) how you interpret the results (e.g. units of the lift).
  • Convergence plot via pyOptSparse and OptView.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.