mdolab / mdolab/OpenAeroStruct

Geometry manipulation variables should be consistent

Open
#269 0 comments 0 reactions 1 assignee View on GitHub

@kanekosh is already working on this.

Since Jun 12, 2020.

Dominant language
Python
Stars
281
Forks
135
PR merge metrics
No merged PRs in 30d

Description

Currently, if you want to add span as a DV to your problem, you add wing.geometry.span whereas if you want to add twist you add wing.twist_cp. These are not consistent and they should be.

Basically, promote up all the other geom DVs like is done for twist.

We may need to figure out a better way to set these up as well, since currently they require an entry in the surface dictionary, as well.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.