Add support for touch events to violent theremin demo
Nobody has claimed this yet.
- Dominant language
- HTML
- Stars
- 1.4k
- Forks
- 443
- PR merge metrics
- No merged PRs in 30d
Description
@normanr commented on Wed Dec 02 2020
It would be nice to be able to use the demo in a touch environment (eg: phone or tablet). (Not required: sound could be continuous after a 'start/down' event until an 'end/up' event is received)
@chrisdavidmills commented on Wed Dec 02 2020
I agree that this would be nice.
For reference:
- Demo repo: https://github.com/mdn/webaudio-examples/tree/main/violent-theremin
- Live demo: https://mdn.github.io/webaudio-examples/violent-theremin/
@normanr commented on Wed Dec 02 2020
(side-note: the event listeners for triggering init should be removed in init, otherwise using the keyboard causes init to be triggered multi times, and DOMExceptions when trying to remove the startMessage that has already been removed).
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the violent-theremin demo in the linked Demo repo and compare its current interaction handling with the live demo. Add touch support for start/down and end/up interactions, and verify the keyboard-triggered init path does not register listeners repeatedly or cause DOMExceptions.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100