Don't upload ssr bundle to bucket
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 233
- Forks
- 61
- Avg merge
- 1d 1h
- Merged PRs (30d)
- 82
Description
As pointed out in https://github.com/mdn/fred/pull/592#discussion_r2288584557, we upload our single-file node app which renders our server components to our bucket: we don't need to do this.
We also duplicate assets like images or icons across out/client/ and out/ssr/ when they're imported in a js file which goes through both the client and ssr rspack config.
We shouldn't upload those files, and we shouldn't duplicate assets: though care needs to be taken, because there are some assets only referred to in either the client or ssr rspack config.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the upload step and the client and SSR rspack configurations, using the discussion on pull request 592 for context. Trace outputs in out/client/ and out/ssr/ and verify that the SSR bundle is not uploaded, shared assets are not duplicated, and assets used by only one configuration remain available.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- build-system, cloud
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100