mdn / mdn/fred

Review workflows that only run on pull requests against main

Open
#1,872 1 comment 0 reactions 1 assignee View on GitHub

@caugner is already working on this.

Since Sep 8, 2026.

p1
Dominant language
JavaScript
Stars
233
Forks
61
Avg merge
1d 1h
Merged PRs (30d)
82

Description

Summary

Several workflows across the MDN org restrict pull_request triggers to branches: [main], e.g. PR Test in mdn/translated-content:

on:
  pull_request:
    branches:
      - main

This prevents the workflow from running on stacked PRs (PRs that target another PR's branch instead of main). Since these workflows typically compute their diff from the PR's own base and head SHAs, the filter seems unnecessary and may be unintentional.

Example

mdn/translated-content#38394 targets another branch, so PR Test never ran, and hence PR review companion never deployed a preview. Lint content (no branch filter) ran as expected.

Proposal

Review the pull_request triggers across MDN repos (mdn/content, mdn/translated-content, mdn/fred, mdn/rari, mdn/yari, mdn/workflows, ...) and drop the branches: [main] filter where the workflow does not actually depend on the base branch.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.