Close survey banner on completion of "link" surveys
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 233
- Forks
- 61
- Avg merge
- 1d 1h
- Merged PRs (30d)
- 82
Description
https://github.com/mdn/fred/pull/1630#discussion_r3346010323
It should still be possible to cross origin postMessage(), though we may need to check our anchor attributes.
This is also quite fiddly to test, let's use this as the opportunity to add e2e tests for the survey component: we'll need a way to spin up different origins locally. We also need some mechanism for altering the survey properties in a test.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the survey component and its completion behavior, then review the postMessage() usage and anchor attributes discussed in the linked pull request. Identify the existing e2e test setup and determine how to run different local origins and alter survey properties. Done means link surveys close their banner on completion and the cross-origin behavior is covered by e2e tests.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend, testing
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100