Require code reviews in content/translated-content
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 233
- Forks
- 61
- Avg merge
- 1d 1h
- Merged PRs (30d)
- 82
Description
In https://github.com/mdn/fred/issues/888, we added the Engineering team as code owners in all repositories, and in https://github.com/mdn/fred/issues/1012, we started enforcing this by enabling the "Require review from Code Owners" option on the default branch protection rule.
This change could not be applied to content/translated-content, because current contributor workflows depend on being able to merge some PRs without approval (translated-content), or without approval from Code Owners (content).
For affected paths, we most likely need to:
- unset code owners for these paths (this is possible by adding a CODEOWNERS entry with only a pattern, and no user or team),
- manage review requests for these paths using a workflow
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading linked issues #888 and #1012, then inspect the current CODEOWNERS, default branch protection, and workflow configuration for content/translated-content. Done means affected pull requests enforce the intended review requirements while preserving the contributor workflows described here.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- github, github-actions
- Domain
- ci-cd, devops
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100