mdn / mdn/dex

Review environment sets `WILDCARD_ENBALED=true` which disables origin-checks in the cloud function

Open
#80 1 comment 0 reactions 1 assignee View on GitHub

@LeoMcA is already working on this.

Since Sep 14, 2026.

cloud-function p1
Dominant language
JavaScript
Stars
6
Forks
4
Avg merge
21h 12m
Merged PRs (30d)
32

Description

Summary

Lately some usage of resources under /shared-assets have been merged into content that were failing on stage and prod environments. Example

The issue has been resolved via https://github.com/mdn/yari/pull/13353 by allowing main and interactive examples origins as well for these assets by the cloud function's proxy.

The reason why this problem did not come up earlier is that the review environment has WILDCARD_ENABLED set, which basically disables all origin-checks in the cloud function.

For better parity with the prod and stage environments, it would be helpful to lock the origin check down there as well, maybe with something like *.review.mdn.allizom.org as the main origin.

URL

https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_anchor_positioning/Using#setting_a_position-area

Reproduction steps
  1. See this issue in content
Expected behavior

I want the same behaviour in review/prod/stage environments

Actual behavior

Shared assets on the review environment worked, but failed on prod/stage environments

Device

Desktop

Browser

Chrome

Browser version

Stable

Operating system

Android

Screenshot

No response

Anything else?

No response

Validations

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.