mdn / mdn/data

`image-set-option` doesn't mark `resolution`/`type` as optional

Open
#924 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

accepting PR
Dominant language
JavaScript
Stars
787
Forks
216
Avg merge
1d 5h
Merged PRs (30d)
6

Description

What information was incorrect, unhelpful, or incomplete?

I noticed that the definition of image-set-option doesn't have resolution/type marked as optional, while it is marked as optional on MDN and in the spec. Note how on MDN and in the spec it's shown as [ <resolution> || type( <string> ) ]?, while here it's shown as [ <resolution> || type(<string>) ]. I'm not sure why this doesn't match what's shown on MDN, as I thought that the formal syntax section is powered by what's in this repository.

What did you expect to see?

I expected the definition in this repo to match what's shown on MDN and in the spec.

Do you have any supporting links, references, or citations?

No response

Do you have anything more you want to share?

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Open css/syntaxes.json and find the image-set-option definition at the referenced location. Compare its optionality with the linked MDN formal syntax and CSS Images specification; done means the repository definition marks resolution/type as optional and matches those references.

Written by the indexing model from the issue text.

Assessment

Tech stack
css
Domain
documentation
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.