Border-Box solution has incorrect values
Nobody has claimed this yet.
- Dominant language
- HTML
- Stars
- 647
- Forks
- 830
- PR merge metrics
- No merged PRs in 30d
Description
This is regarding the solution in:
https://github.com/mdn/css-examples/blob/24f806373566e7c34f3aa7bf55bd097a6fff00d8/learn/solutions.md?plain=1#L66
From task in:
https://developer.mozilla.org/en-US/docs/Learn_web_development/Core/Styling_basics/Box_model#playing_with_box_models
Very minor nitpick, the answer specifies a width of 390 and height of 240, but I believe that is incorrect. These values appear to include margin in the width/height of the border-box, which should not be included in the border-box size, and so the values should be 350 x 200. Happy to open a PR if it would be accepted.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with learn/solutions.md at the linked Border-Box solution and compare it with the Box model exercise linked in the issue. Verify the stated border-box dimensions against the example's margin and padding, update the incorrect values, and confirm the solution matches the exercise.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- css
- Domain
- documentation
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Quiet
- Clarity
- Clearly specified
- Newbie friendliness
- 82/100