Review Companion should show summary of changes
Nobody has claimed this yet.
- Dominant language
- JSON
- Stars
- 5.8k
- Forks
- 2.6k
- Avg merge
- 1d 21h
- Merged PRs (30d)
- 186
Description
What type of issue is this?
Infrastructure issue
What is the issue?
In https://github.com/mdn/browser-compat-data/pull/28637#pullrequestreview-3567886593, most features tagged with web-features:attribution-reporting were changed, but not all.
The only way to find this is out was to manually search for the web-features tag, and check each feature.
What behavior were you expecting?
It would have been extremely helpful if the review companion comment would have included a comment like this:
web-features
- attribution-reporting (84 % features updated / 16 of 19)
What version(s) of BCD is the issue present in?
- The current BCD release
- The current version of the
mainbranch
Do you have anything more you want to share?
Break downs by browser would also be interesting.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the Review Companion implementation that generates pull request review comments, then trace how web-features tags are collected and compared. Done means the comment summarizes updated versus total tagged features, with the proposed attribution-reporting example represented accurately; browser breakdowns are an additional idea in the issue.
Written by the indexing model from the issue text.
Assessment
- Domain
- ci-cd, tooling
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100