async option is not true async 3.1.10
Open
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 8.1k
- Forks
- 846
- PR merge metrics
- No merged PRs in 30d
Description
We are using 3.1.10 with NodeJS 20.9.0.
I read that there is an async option for rendering templates. Upon further inspection of the source code, this is not a real Async behavior as the internals of this library use these calls to load file data.
- fs.existsSync
- fs.readFileSync
Any hopes to Promisify these calls to be truly async?
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing the async rendering path in the source code and locate its uses of fs.existsSync and fs.readFileSync. Check how those calls affect template loading under NodeJS 20.9.0; done means the async option no longer performs synchronous file reads while preserving rendering behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, nodejs
- Domain
- backend
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100