mcollina / mcollina/msgpack5

msgpack.decode() not working for chrome >=60

Open
#57 21 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
499
Forks
77
PR merge metrics
No merged PRs in 30d

Description

screenshot from 2017-08-14 12-06-56

It's working fine for chrome versions, before 60. Also not working on latest firefox! Please do review decode() function.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the reported decode() failure in Chrome 60 or later and the latest Firefox, comparing it with earlier Chrome versions. Inspect the decode() implementation and use the issue screenshot and existing discussion as context; done means decoding works in the affected browsers without regressing older Chrome versions.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, node.js
Domain
web-dev
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.