Fix in the encoder.js
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 499
- Forks
- 77
- PR merge metrics
- No merged PRs in 30d
Description
Hi,
we needed an amendment to the encoder.js to make it work in our codebase. You can find it at: https://github.com/sashee/msgpack5/commit/35cb7a6b43d13e011174ab4d097238e3355b8947 .
We are unsure whether it is a bug in the library or in the remote server we are using. Feel free to use it and/or incorporate it in your codebase if you see fit. Please close this issue if this change is deemed unnecessary.
Note: I am not the author of the patch, so I can provide little help what exactly it does. I ran the tests and it did not break any.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by inspecting encoder.js and the linked commit 35cb7a6b43d13e011174ab4d097238e3355b8947. Run the existing tests, then reproduce the reported behavior against the remote server to determine whether the problem is in msgpack5 or the server. Done means establishing whether the change is necessary and, if so, validating it without breaking the test suite.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, node.js
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100