mcollina / mcollina/msgpack5

SharedArrayBuffer warning in Chrome

Open
#102 3 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
499
Forks
77
PR merge metrics
No merged PRs in 30d

Description

Hi!

Recently upgraded to version 5.3.2 and now getting the following warning in Chrome:

image

It seems that in msgpack5.js there is code that checks for SharedArrayBuffer, but it doesn't actually use it as part of the functionality.

Chrome version 91 (yet to be released) will apparently require a web page to be cross-origin isolated, requiring the use of new response headers, etc. Only sites modified as such will be able to use SharedArrayBuffer.

I have tried our site in Chrome DEV version 91, and all appears fine - in fact, it seems that the msgpack library no longer makes any checks on SharedArrayBuffer in this context.

May I please ask if there is an intention to use SharedArrayBuffer in earnest in the future, or will the msgpack5 library always gracefully "degrade"?

Many thanks,

Nick

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by inspecting the SharedArrayBuffer check in msgpack5.js and reproduce the warning in Chrome 91 or the reported Chrome DEV version. Clarify whether the library should continue checking for SharedArrayBuffer or gracefully degrade, then document the decision and its expected behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
backend
Issue type
Bug
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.