mcfunley / mcfunley/experiment-model
"What percentage of visits will see the change?" breaks on 99.0%+
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 54
- Forks
- 12
- PR merge metrics
- No merged PRs in 30d
Description
The calculator is awesome--thanks!
I tried inputting 99.99%, and got a really weird answer. I'm pretty sure its because of the way JS processes decimals. Maybe a solution is to not allow any values between 99.0% and 100%, non-inclusive? Not sure what the best solution would be.
Anyways, just wanted to leave this here in case anyone uses this in the future.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the calculator result with an input of 99.99% and inspect how the percentage is processed. Determine the expected behavior for values between 99% and 100%, then verify that the calculator gives a sensible result or clearly rejects unsupported values.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- web-dev
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100