mcabbott / mcabbott/SliceMap.jl
Difference in the implementation of slicemap and mapcols
Nobody has claimed this yet.
- Dominant language
- Julia
- Stars
- 31
- Forks
- 3
- PR merge metrics
- No merged PRs in 30d
Description
The implementation of slicemap and mapcols is fundamentally different. Intuitively, this is relatively weird because
mapcols(f,M)=slicemap(f,M,dims=1)
and
slicemap(f,M,dims=1)=reshape(mapcols(f,reshape(M,size(M,1),:)),size(M))
(if dims is not equal to 1, then one could just use PermutedDimsArray)
After some (light) testing, I have the impression that using mapcols is about 25% faster than using slicemap. Is that a general result or specific to my application? Would there be any advantage on using either one or the other implementations?
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading the implementations of slicemap and mapcols, then benchmark the equivalent expressions described in the issue. Done means explaining the observed performance difference and determining whether either implementation should be changed or kept distinct.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- julia
- Domain
- performance
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 30/100