mcabbott / mcabbott/AxisKeys.jl

Should subtypes of `Factorization` maintain keys?

Open
#31 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Julia
Stars
154
Forks
31
PR merge metrics
No merged PRs in 30d

Description

I'm wondering if we should try to maintain the keys on the components of Factorization types like SVD and Cholesky? I realize it wouldn't apply to all components, but for upper and lower matrices it might be a reasonable to avoid prematurely dropping keys?

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The issue concerns Factorization subtypes such as SVD and Cholesky, especially whether upper and lower matrix components should retain keys. No files, tests, or entry points are named, so first identify where these factorization component types are defined and how keys are currently discarded. Done would require a decided, documented behavior and corresponding implementation or tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
julia
Domain
data
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
20/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.