mcabbott / mcabbott/AxisKeys.jl
wrapdims(::DataFrame) produces incorrect results when not all key combinations are present
Open
Nobody has claimed this yet.
- Dominant language
- Julia
- Stars
- 154
- Forks
- 31
- PR merge metrics
- No merged PRs in 30d
Description
df = DataFrame([
(x="a", y="a", z=1),
(x="a", y="b", z=2),
(x="b", y="b", z=3),
])
wrapdims(df, :z, :x, :y)
The result varies, but here's one example
("a") ("b")
("a") 1 2
("b") 4615108224 3
I think the matrix should be initialized with an undefined value rather than an arbitrary value (maybe missing)?
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Search the implementation of wrapdims(::DataFrame) and reproduce the example from the issue. Inspect how the missing ("b", "a") combination is initialized and determine the intended representation from surrounding behavior. Done should include a regression test covering incomplete key combinations and prevent arbitrary values from appearing in the result.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- julia
- Domain
- data
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100