mc2-project / mc2-project/opaque-sql
Null checking for Min/Max
Nobody has claimed this yet.
- Dominant language
- Scala
- Stars
- 190
- Forks
- 70
- PR merge metrics
- No merged PRs in 30d
Description
From #23:
Setting init value to zero (default for IntegerType currently) might not return valid results when data contains also negative values.
The existing null checks are not sufficient since they only check the nullity of the current max, not the new value.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the existing null checks in src/main/scala/edu/berkeley/cs/rise/opaque/Utils.scala at the linked location, then trace the Min and Max handling. Check cases containing negative values and nulls, including whether both the current aggregate and incoming value are handled; the issue is done when these cases return valid Min/Max results.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- scala
- Domain
- data
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100