mblode / mblode/vscode-twig-language

Formatting indented block comments pushes them out to infinity

Open
#41 13 comments 5 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

formatter
Dominant language
JavaScript
Stars
45
Forks
7
PR merge metrics
No merged PRs in 30d

Description

twig indent bug

Version: 1.39.0-insider (user setup)
Commit: bdd1971f2cd9d08a8a90e02740f1850afe03da66
Date: 2019-09-17T06:02:08.670Z
Electron: 6.0.9
Chrome: 76.0.3809.146
Node.js: 12.4.0
V8: 7.6.303.31-electron.0
OS: Windows_NT x64 10.0.18362

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the behavior shown in the attached GIF with an indented Twig block comment in the vscode-twig-language extension. Trace the extension's formatting path and identify how indentation is repeatedly applied; done means formatting keeps the comment at a stable indentation instead of pushing it out indefinitely, with a regression check if the repository provides one.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, vscode
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Active
Clarity
Needs clarification
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.