mayadata-io / mayadata-io/quay-logs
Restricted filenames in Windows.
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 1
- Forks
- 1
- PR merge metrics
- No merged PRs in 30d
Description
One more thing I figured out that in windows we have the restriction over filenames that it cannot contain special characters
that's why will have to change the filenames, especially for windows. So will this cause any problems? I think writing conditional codes for the different OS will solve the problem.
I previously thought that changing filenames : to - will break the codes but no it works well because we only focus on .json extension and not the filename. But if you think that it will hamper anything else then do let me know.
Originally posted by @srikant-code in https://github.com/mayadata-io/growth-metrics/issues/16#issuecomment-683371724
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No source file or test is identified in the issue. Start by locating the Go code that generates these JSON filenames, then reproduce the restricted-filename case on Windows; done means filenames are valid there while the existing JSON lookup behavior remains intact.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- operating-systems
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100