maxs15 / maxs15/react-native-spinkit

No `export default` of Component in index.js

Open
#91 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Objective-C
Stars
2.4k
Forks
307
PR merge metrics
No merged PRs in 30d

Description

I noticed that `index.js` is using `module.exports = SpinKit` rather than `export default SpinKit`. Is there a reason for this? Or can we switch it to using the ES modules syntax? My linter can't resolve the default import because there's not default export. Small issue, but don't see why we can't do it since SpinKit is already written using `import` rather than `require`

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with index.js and inspect how SpinKit is currently imported and exported, then check the package's module conventions and linter behavior. Done means the supported default import resolves correctly without breaking the existing React Native component export.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, react-native
Domain
mobile
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.