maxs15 / maxs15/react-native-spinkit
ThreeBounce has empty space
Nobody has claimed this yet.
- Dominant language
- Objective-C
- Stars
- 2.4k
- Forks
- 307
- PR merge metrics
- No merged PRs in 30d
Description
i tried to use ThreeBounce but the more size i go the more top padding i get. and it's not possible to handle it from the design
ex. https://ibb.co/mX86kF
<Spinner type="ThreeBounce" size={ 60 } />
i figure out this is because of the circle.frame it gives the Y value as the hight / 2
i guess the Y value needs to be 0 so the spinner start from the begging and doesn't force the upper empty space
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate the ThreeBounce implementation and inspect how its circle.frame is calculated, especially the Y value when the spinner size increases. Reproduce the issue with a size of 60 and verify that the rendered spinner no longer has unwanted top padding. Confirm the change across the ThreeBounce rendering path.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- objective-c, react-native
- Domain
- mobile
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100