maxs15 / maxs15/react-native-spinkit

Android React Native 0.82 Support

Open
#145 0 comments 3 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Objective-C
Stars
2.4k
Forks
307
PR merge metrics
No merged PRs in 30d

Description

The latest version of this library (1.5.1) gives a compilation problem for android:

FAILURE: Build failed with an exception.
*Where:
Build file '*/node_modules/react-native-spinkit/android/build.gradle' line: 7

* What went wrong:
A problem occurred evaluating project ':react-native-spinkit'.
> Could not find method jcenter() for arguments [] on repository container of type org.gradle.api.internal.artifacts.dsl.DefaultRepositoryHandler.]

This is fixed with the following patch:

patches/react-native-spinkit+1.5.1.patch

diff --git a/node_modules/react-native-spinkit/android/build.gradle b/node_modules/react-native-spinkit/android/build.gradle
index 9f02021..4af9f35 100644
--- a/node_modules/react-native-spinkit/android/build.gradle
+++ b/node_modules/react-native-spinkit/android/build.gradle
@@ -4,7 +4,7 @@ buildscript {
     }
     repositories {
         google()
-        jcenter()
+        mavenCentral()
     }
 
     dependencies {
@@ -33,7 +33,7 @@ android {
 repositories {
     mavenLocal()
     google()
-    jcenter()
+    mavenCentral()
     maven {
         // All of React Native (JS, Obj-C sources, Android binaries) is installed from npm
         url "$rootDir/../node_modules/react-native/android"

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with patches/react-native-spinkit+1.5.1.patch and the reported Android build failure in node_modules/react-native-spinkit/android/build.gradle. Verify the patch applies for React Native 0.82 and that the Android build no longer fails while evaluating the jcenter repositories.

Written by the indexing model from the issue text.

Assessment

Tech stack
android, react-native
Domain
build-system, mobile
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.