maxs15 / maxs15/react-native-modalbox
backButtonClose cannot be safely updated when the modal is open
Open
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 2.9k
- Forks
- 496
- PR merge metrics
- No merged PRs in 30d
Description
If e.g. backButtonClose is true when the modal is opened, and then set to false and the modal is closed, the BackHandler will not be unregistered and all future back button actions in the app will not work as expected.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing the backButtonClose handling and BackHandler registration and unregistration when a modal is opened, updated, and closed. Reproduce the sequence with backButtonClose changing from true to false while open. Done means closing the modal unregisters BackHandler and later back-button actions in the app continue to work.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- mobile
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100