maxs15 / maxs15/react-native-modalbox

1st modal flickers after closing 2nd children modal

Open
#265 9 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
2.9k
Forks
496
PR merge metrics
No merged PRs in 30d

Description

I got on one of my app screens, a button, that opens a modal, this modal has also a button, that shows a fullscreen modal. Whenever I close the latter, the first modal that is behind, flickers super fast that you can see for a millisecond the screen beneath and then it renders back again.

Is there any way to solve this issue? Haven't tested on Android, but i'm seeing this on iPhone X simulator iOS 12.1 and also on my iPhone 6S (device).

This is the way i'm setting up the 2nd modal which is full screen:

```
style={styles.modal}
backdrop={false}
isOpen={this.state.modalOpened}
onOpened={ () => this.setState({ modalOpened: true })}
onClosed={ () => this.setState({ modalOpened: false })}
position={'top'}
swipeToClose={false}
keyboardTopOffset={0}
coverScreen={true}
entry={'bottom'}
backdropPressToClose={false}>
```

RN info:
```
"react": "16.6.3",
"react-native": "0.57.8",
"react-native-modalbox": "^1.6.0",
```

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the nested modal close flow on iOS with the shown react-native-modalbox props, comparing the first modal with the screen beneath it. Read the modal open and close lifecycle in the package and verify that closing the fullscreen child no longer briefly reveals the underlying screen.

Written by the indexing model from the issue text.

Assessment

Tech stack
ios, javascript, react-native
Domain
mobile
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.