maxs15 / maxs15/react-native-modalbox

[ANDROID] Modal size adjusts when user shares content

Open
#258 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
2.9k
Forks
496
PR merge metrics
No merged PRs in 30d

Description

Steps to recreate:
1. open modal
2. take a screenshot
3. swipe down to share via app (i used slack)
4. click "X" in top left to close or share your image (either way don't close keyboard)
5. comes back to app with adjusted height

See attached image for example.
```
{this._readinessSurveyModalRef = ref;}}
swipeToClose={false}
>

...

```
![screenshot_20181218-092743](https://user-images.githubusercontent.com/9324607/50313624-fafdc600-0479-11e9-9cb7-cfb41b7f2413.png)

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue using the listed Android steps and the provided Modal configuration, including sharing through Slack and returning without closing the keyboard. Inspect the modal behavior on return from the share flow. Done means the modal height remains correct after closing or completing the share action.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, react-native
Domain
mobile
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.