maxs15 / maxs15/react-native-modalbox

SafeAreaView with coverscreen

Open
#227 2 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
2.9k
Forks
496
PR merge metrics
No merged PRs in 30d

Description

When coverscreen prop is specified, SafeAreaView inside the modal does not work.

<Modal
        onClosed={onClosed}
        isOpen={true}
        position="bottom"
        coverScreen={true}
        style={{ height: 500 }}
      >
        <SafeAreaView style={composeStyles("occupy")}>
                ...Other code...
        </SafeAreaView>
</Modal>
screen shot 2018-06-18 at 9 06 42 pm

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the example with Modal using coverScreen={true}, position="bottom", and the nested SafeAreaView. Inspect how the modal's cover-screen behavior interacts with SafeAreaView on the affected platform; done means the SafeAreaView applies its insets correctly inside the modal. No source file or test is named in the issue.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, react-native
Domain
mobile-dev
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.