maxs15 / maxs15/react-native-modalbox
open() method does not cancel close()
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 2.9k
- Forks
- 496
- PR merge metrics
- No merged PRs in 30d
Description
When using these methods, close() can cancel open(), however, this does not work the other way around. Looking at the code itself, open() runs the function that should stop the close() animation, so I assume this is the intent.
Reproduce:
this.refs.modalRef.close()
this.refs.modalRef.open()
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the open() and close() entry points in the modal component and reproduce the sequence close() followed by open(). Trace how each method controls the other animation. Done means calling open() immediately after close() reliably cancels the closing animation and leaves the modal open.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, react-native
- Domain
- mobile
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100