maxs15 / maxs15/react-native-modalbox

backdropPressToClose & swipeToClose won't work together

Open
#185 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
2.9k
Forks
496
PR merge metrics
No merged PRs in 30d

Description

backdropPressToClose & swipeToClose won't work synonymously. If I have backdropPressToClose set to true and swipeToClose set to false, backdropPressToClose will work as it should, and visa versa. For some reason when both are set to true it seems to give swipeToClose precedence and backdropPressToClose won't work.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the issue in the React Native modal component with both backdropPressToClose and swipeToClose enabled, then compare behavior when each option is enabled alone. Trace the close handling for the backdrop and swipe interactions. Done means both interactions close the modal when both options are true.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, react-native
Domain
mobile
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.