maxs15 / maxs15/react-native-modalbox

[Android] Touches below screen's center will close the modal, regardless of the position

Open
#18 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
2.9k
Forks
496
PR merge metrics
No merged PRs in 30d

Description

Hello,
Great work on the modal (Y).
Im testing this on android. Here is a gif that explains everything.
Im using react-native 0.14

modalbox_issue

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the Android behavior described in the issue using React Native 0.14 and compare it with the attached GIF. Then trace the modal's touch and dismissal handling to find why touches below the screen center close it regardless of position. Done means the modal remains open when a touch occurs outside the intended dismissal area.

Written by the indexing model from the issue text.

Assessment

Tech stack
android, javascript, react-native
Domain
mobile
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.