maxking / maxking/docker-mailman
[BUG] gunicorn-extra.cfg completelly overrides existing one
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 278
- Forks
- 121
- PR merge metrics
- No merged PRs in 30d
Description
Tag/version of Container Images
0.5.3
The initialisation code in the docker-entrypoint.sh for mailman-core uses override shell semantics > rather than append to the end of the file >> as everywhere else in the code, where extra configs are provided.
if [[ -e /opt/mailman/gunicorn-extra.cfg ]]
then
echo "Found [webserver] configuration file at /opt/mailman/gunicorn-extra.cfg"
cat /opt/mailman/gunicorn-extra.cfg > /etc/gunicorn.cfg
fi
Not really sure if it's a bug or a feature, but at least, worth a comment in the code?
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with core/docker-entrypoint.sh around the gunicorn-extra.cfg handling at line 216, then compare it with the other extra-configuration handling in the script. Confirm the intended behavior for an existing /etc/gunicorn.cfg; done means the extra configuration no longer unexpectedly replaces existing settings and the surrounding behavior remains consistent.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- docker, shell
- Domain
- devops
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 50/100