maxking / maxking/docker-mailman
[BUG] Special characters in the password break psql command
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 278
- Forks
- 121
- PR merge metrics
- No merged PRs in 30d
Description
Tag/version of Container Images
0.5.3
We do use a password generator to make database passwords. This time password had a % sign inside it.
Container initialisation started to fail with the:
psql: error: invalid percent-encoded token: "AmJawatHen%queifJof5"
Postgres is unavailable - sleeping
psql: error: invalid percent-encoded token: "AmJawatHen%queifJof5"
Postgres is unavailable - sleeping
psql: error: invalid percent-encoded token: "AmJawatHen%queifJof5"
Postgres is unavailable - sleeping
psql: error: invalid percent-encoded token: "AmJawatHen%queifJof5"
Postgres is unavailable - sleeping
The same message was both mailman-core and mailman-web containers, so it looks like in the wait_for_postgres function.
I'm not sure what would be the best fix here, except, maybe, a special note in the documentation that % sign has to be escaped, if present in the password.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the wait_for_postgres function used during initialization of the mailman-core and mailman-web containers, and reproduce the failure with a PostgreSQL password containing a percent sign. Done means container initialization succeeds and PostgreSQL readiness checks work with that password.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- docker, postgresql
- Domain
- database, devops
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100