max-mapper / max-mapper/yo-yo

Why does yo-yo reset the value property of select elements?

Open
#58 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
1.3k
Forks
46
PR merge metrics
No merged PRs in 30d

Description

I've noticed that yo-yo fiddles with the selection state of my select elements when I change which option is selected by setting its selected property.

By debugging, I figured out that it's due to this code. Should it instead copy from t to f? I don't understand why the mutating element should get modified, it seems the opposite should happen.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at index.js line 31 and reproduce the reported case with a select element whose option selection changes through the selected property. Trace which element is mutated during diffing, then verify that the selection state is preserved without breaking the existing behavior described by the issue.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.